Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET] Test and fix exports diagnostics #88495

Merged

Conversation

paulloz
Copy link
Member

@paulloz paulloz commented Feb 18, 2024

Leaving this as draft until the following is merged:


  • Add tests for the following diagnostics: GD0101, GD0102, GD0103, GD0104, GD0105, GD0106, GD0107.
  • Fix GD0101 not being reported any more (was filtering static classes before reporting).
  • Fix GD0107 not preventing Node members from being exported from not-Node types.

@paulloz paulloz added this to the 4.3 milestone Feb 18, 2024
@paulloz paulloz force-pushed the dotnet/test-and-fix-exports-diagnostics branch from b3d566e to fa5fe4c Compare February 18, 2024 14:01
- Add tests for the following diagnostics: GD0101, GD0102, GD0103, GD0104, GD0105, GD0106, GD0107.
- Fix GD0101 not being reported any more (was filtering static classes before reporting).
- Fix GD0107 not preventing `Node` members from being exported from not-`Node` types.
@paulloz paulloz force-pushed the dotnet/test-and-fix-exports-diagnostics branch from fa5fe4c to 88ad4e6 Compare February 20, 2024 13:35
@paulloz paulloz marked this pull request as ready for review February 20, 2024 14:48
@paulloz paulloz requested a review from a team as a code owner February 20, 2024 14:48
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@akien-mga akien-mga merged commit aeaec00 into godotengine:master Feb 21, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@paulloz paulloz deleted the dotnet/test-and-fix-exports-diagnostics branch April 19, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants